Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add upper bound on tar-unix 3 #184

Merged
merged 1 commit into from
Aug 29, 2024
Merged

Conversation

shonfeder
Copy link
Contributor

Corresponding to ocaml/opam-repository#26331

@shonfeder
Copy link
Contributor Author

Tracking issue for followup to update to the new api: #185

Copy link

@punchagan punchagan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking care of this!

@shonfeder
Copy link
Contributor Author

From the lower bounds check:

ASSERT Final result
[failure] Could not close database! It is busy.
          Raised at Stdlib.failwith in file "stdlib.ml", line 29, characters 17-33
          Called from Obuilder__Build.Make.finish in file "lib/build.ml", line 327, characters 4-24
          Called from Lwt.Sequential_composition.finalize.(fun) in file "src/core/lwt.ml", line 2251, characters 21-28
          Called from Lwt.Sequential_composition.try_bind.create_result_promise_and_callback_if_deferred.callback in file "src/core/lwt.ml", line 2132, characters 23-27

From debian 12 and 2 fedora instances:

test.exe: [INFO] b1: "(from base)"
test.exe: [INFO] Base image not present; importing "base"…
test.exe: [INFO] Exec "sudo" "--" "mkdir" "-m" "755" "--" "/tmp/build_e7f718_dune/mock-store-320eb3/cae662172fd450bb0cd710a769079c05bfc5d8e35efa6576edc7d0377afdd4a2-tmp/rootfs"
exec: [|sudo; --; mkdir; -m; 755; --;
        /tmp/build_e7f718_dune/mock-store-320eb3/cae662172fd450bb0cd710a769079c05bfc5d8e35efa6576edc7d0377afdd4a2-tmp/rootfs|]
test.exe: [INFO] Exec "docker" "create" "--" "base"
exec: [|docker; create; --; base|]
test.exe: [INFO] Exec "docker" "export" "--" "base-7"
exec: [|docker; export; --; base-7|]
test.exe: [INFO] Exec "sudo" "--" "tar" "-C" "/tmp/build_e7f718_dune/mock-store-320eb3/cae662172fd450bb0cd710a769079c05bfc5d8e35efa6576edc7d0377afdd4a2-tmp/rootfs" "-xf" "-"
exec: [|sudo; --; tar; -C;
        /tmp/build_e7f718_dune/mock-store-320eb3/cae662172fd450bb0cd710a769079c05bfc5d8e35efa6576edc7d0377afdd4a2-tmp/rootfs;
        -xf; -|]
test.exe: [INFO] Exec "docker" "rm" "--force" "--" "base-7"
exec: [|docker; rm; --force; --; base-7|]
docker rm --force "base-7"
test.exe: [INFO] Exec "docker" "image" "inspect" "--format" "{{range .Config.Env}}{{print . "\x00"}}{{end}}" "--" "base"
exec: [|docker; image; inspect; --format;
        {{range .Config.Env}}{{print . "\x00"}}{{end}}; --; base|]
test.exe: [INFO] b1: "---> saved as \"cae662172fd450bb0cd710a769079c05bfc5d8e35efa6576edc7d0377afdd4a2\""
test.exe: [INFO] b1: "/: (run (shell Wait))"
test.exe: [INFO] b1: "Wait\n"
test.exe: [INFO] b2: "(from base)"
test.exe: [INFO] b2: "---> using \"cae662172fd450bb0cd710a769079c05bfc5d8e35efa6576edc7d0377afdd4a2\" from cache"
test.exe: [INFO] b2: "/: (run (shell Wait))"
test.exe: [INFO] b2: "Wait\n"
test.exe: [INFO] User cancelled job (users now = 1)
ASSERT User 1 result
test.exe: [INFO] User cancelled job (users now = 0)
ASSERT User 2 result
ASSERT Build cancelled
[exception] Unix.Unix_error(Unix.ENOENT, "lstat", "/tmp/build_e7f718_dune/mock-store-320eb3/state/db/db.sqlite-shm")
            Raised by primitive operation at Lwt_unix.self_result in file "src/unix/lwt_unix.cppo.ml", line 246, characters 14-31

@shonfeder
Copy link
Contributor Author

Parts of the CI have been broken here at least since 12373f1 but these failures seem new, and maybe a problem in the infrastructure itself?

@shonfeder
Copy link
Contributor Author

shonfeder commented Aug 29, 2024

Those failures are from flaky tests that have apparently been that way for some time: #186

@shonfeder shonfeder merged commit d21e5bf into ocurrent:master Aug 29, 2024
9 checks passed
@shonfeder shonfeder deleted the tar-upper-bound branch August 29, 2024 02:55
shonfeder added a commit to ocurrent/ocluster that referenced this pull request Aug 29, 2024
Pulling in ocurrent/obuilder#184

This will fix the current CI error resulting from missing upper bounds
on the tar package.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants